[17.0][FIX] hr_shift: prevent shift planning being counted as lunch #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @Abranes could you take a look at this issue when you have a moment? |
pedrobaeza
changed the title
pedrobaeza
approved these changes
Sep 12, 2025
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
I suppose we need to define an extra field in shifts for specifying the lunch time and take that into account for the method.
/ocabot merge patch
Please fw-port it to 18.
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at feaa1ce. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] hr_shift: prevent shift planning being counted as lunch
This fixes a bug in the hr_shift module where shift planning records were treated as "lunch"
during worked hours calculation, subtracting them from the employee's worked hours.
Now, the planned shifts are correctly counted as regular working hours.
Closes #20